Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pipeline log output download #1023

Merged
merged 1 commit into from
Jul 17, 2022

Conversation

lafriks
Copy link
Contributor

@lafriks lafriks commented Jul 16, 2022

Fixes #566

Download button is displayed only when you move mouse into log display element.

Download button will be available only when build step is finished (has end time)

attels

@6543 6543 added ui frontend related feature add new functionality labels Jul 17, 2022
@6543 6543 added this to the 1.0.0 milestone Jul 17, 2022
@6543
Copy link
Member

6543 commented Jul 17, 2022

web/src/components/repo/build/BuildLog.vue
137:9 warning Unexpected console statement no-console

✖ 1 problem (0 errors, 1 warning)

web/src/assets/locales/en.json Outdated Show resolved Hide resolved
web/src/components/repo/build/BuildLog.vue Outdated Show resolved Hide resolved
web/src/components/repo/build/BuildLog.vue Outdated Show resolved Hide resolved
web/src/components/repo/build/BuildLog.vue Outdated Show resolved Hide resolved
@lafriks
Copy link
Contributor Author

lafriks commented Jul 17, 2022

web/src/components/repo/build/BuildLog.vue 137:9 warning Unexpected console statement no-console

heavy_multiplication_x 1 problem (0 errors, 1 warning)

Moved that out to common notification function so that it could be reused

@6543
Copy link
Member

6543 commented Jul 17, 2022

lint issue :X

web/src/compositions/useNotifications.ts Outdated Show resolved Hide resolved
web/src/compositions/useNotifications.ts Outdated Show resolved Hide resolved
web/src/components/repo/build/BuildLog.vue Outdated Show resolved Hide resolved
@6543
Copy link
Member

6543 commented Jul 17, 2022

Uncaught (in promise) ReferenceError: notifyErr is not defined

and repo/build-view is empty

@lafriks
Copy link
Contributor Author

lafriks commented Jul 17, 2022

Rebased and fixed

@anbraten anbraten changed the title Add step output download button Add pipeline log output download button Jul 17, 2022
@anbraten anbraten changed the title Add pipeline log output download button Add pipeline log output download Jul 17, 2022
@anbraten anbraten merged commit f654e1f into woodpecker-ci:master Jul 17, 2022
@lafriks lafriks deleted the feat/download_log branch July 17, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature add new functionality ui frontend related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Download pipeline log
3 participants